From 980e84a3a9abefbdbcf14c15b3cef7d61088865e Mon Sep 17 00:00:00 2001 From: hausman-gdit Date: Mon, 11 Dec 2023 12:03:45 -0500 Subject: [PATCH 01/29] 8 --- frontend/src/constants/logicConstants.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/frontend/src/constants/logicConstants.js b/frontend/src/constants/logicConstants.js index 9cb9dd62..3111982a 100644 --- a/frontend/src/constants/logicConstants.js +++ b/frontend/src/constants/logicConstants.js @@ -136,8 +136,9 @@ export const RULES = Object.freeze({ enabledNested: true, }, [RULES.ROI_LARGE]: { + // zzz #8 name: "Abs(Residual of interest) too large", - notes: val => `|Residual for Dose Group Near BMD| > ${val}`, + notes: val => `|Residual Near BMD| > ${val}`, hasThreshold: true, enabledContinuous: true, enabledDichotomous: true, From a6239cc031ed0c8da7d4559ec5815cff7d23359d Mon Sep 17 00:00:00 2001 From: hausman-gdit Date: Thu, 14 Dec 2023 14:21:47 -0500 Subject: [PATCH 02/29] 25a, 26, 30 comment --- frontend/src/components/IndividualModel/GoodnessFit.js | 2 +- .../src/components/IndividualModel/ModelParameters.js | 10 +--------- .../src/components/Output/Multitumor/GoodnessFit.js | 2 +- 3 files changed, 3 insertions(+), 11 deletions(-) diff --git a/frontend/src/components/IndividualModel/GoodnessFit.js b/frontend/src/components/IndividualModel/GoodnessFit.js index 09ead3d8..e70063dd 100644 --- a/frontend/src/components/IndividualModel/GoodnessFit.js +++ b/frontend/src/components/IndividualModel/GoodnessFit.js @@ -10,7 +10,7 @@ import {ff} from "@/utils/formatters"; const hdr_c_normal = [ "Dose", "Size", "Observed Mean", "Calculated Mean", "Estimated Mean", "Observed SD", "Calculated SD", "Estimated SD", "Scaled Residual", - ], + ], // zzz #30 hdr_c_lognormal = [ "Dose", "Size", "Observed Mean", "Calculated Median", "Estimated Median", "Observed SD", "Calculated GSD", "Estimated GSD", "Scaled Residual", diff --git a/frontend/src/components/IndividualModel/ModelParameters.js b/frontend/src/components/IndividualModel/ModelParameters.js index d70b58e8..951ab64e 100644 --- a/frontend/src/components/IndividualModel/ModelParameters.js +++ b/frontend/src/components/IndividualModel/ModelParameters.js @@ -29,8 +29,6 @@ class ModelParameters extends Component { Variable Estimate Standard Error - Lower Confidence - Upper Confidence @@ -44,7 +42,7 @@ class ModelParameters extends Component { <> Bounded @@ -53,12 +51,6 @@ class ModelParameters extends Component { )} {bounded ? "NA" : parameterFormatter(parameters.se[i])} - - {bounded ? "NA" : parameterFormatter(parameters.lower_ci[i])} - - - {bounded ? "NA" : parameterFormatter(parameters.upper_ci[i])} - ); })} diff --git a/frontend/src/components/Output/Multitumor/GoodnessFit.js b/frontend/src/components/Output/Multitumor/GoodnessFit.js index d896efcb..b0a9a0ef 100644 --- a/frontend/src/components/Output/Multitumor/GoodnessFit.js +++ b/frontend/src/components/Output/Multitumor/GoodnessFit.js @@ -10,7 +10,7 @@ import {ff} from "@/utils/formatters"; const hdr_c_normal = [ "Dose", "Size", "Observed Mean", "Calculated Mean", "Estimated Mean", "Observed SD", "Calculated SD", "Estimated SD", "Scaled Residual", - ], + ], // zzz #30 hdr_c_lognormal = [ "Dose", "Size", "Observed Mean", "Calculated Median", "Estimated Median", "Observed SD", "Calculated GSD", "Estimated GSD", "Scaled Residual", From ffcd74241c8fa3b1787364ca44880be97d9138f4 Mon Sep 17 00:00:00 2001 From: hausman-gdit Date: Thu, 14 Dec 2023 14:30:04 -0500 Subject: [PATCH 03/29] 27, 29, 33, 34, 35 --- .../src/components/IndividualModel/ContinuousDeviance.js | 2 +- .../IndividualModel/ContinuousTestOfInterest.js | 2 +- frontend/src/components/IndividualModel/GoodnessFit.js | 9 +++++---- .../src/components/IndividualModel/ModelParameters.js | 6 +++++- frontend/src/components/Output/Multitumor/GoodnessFit.js | 6 +++--- 5 files changed, 15 insertions(+), 10 deletions(-) diff --git a/frontend/src/components/IndividualModel/ContinuousDeviance.js b/frontend/src/components/IndividualModel/ContinuousDeviance.js index e5c30b04..11af916d 100644 --- a/frontend/src/components/IndividualModel/ContinuousDeviance.js +++ b/frontend/src/components/IndividualModel/ContinuousDeviance.js @@ -20,7 +20,7 @@ class ContinuousDeviance extends Component { - Likelihoods of Interest + Likelihoods Model diff --git a/frontend/src/components/IndividualModel/ContinuousTestOfInterest.js b/frontend/src/components/IndividualModel/ContinuousTestOfInterest.js index 6afca764..888aa5ca 100644 --- a/frontend/src/components/IndividualModel/ContinuousTestOfInterest.js +++ b/frontend/src/components/IndividualModel/ContinuousTestOfInterest.js @@ -22,7 +22,7 @@ class ContinuousTestOfInterest extends Component { - Test of Interest + Tests of Mean and Variance Fits Test diff --git a/frontend/src/components/IndividualModel/GoodnessFit.js b/frontend/src/components/IndividualModel/GoodnessFit.js index e70063dd..1dd0766e 100644 --- a/frontend/src/components/IndividualModel/GoodnessFit.js +++ b/frontend/src/components/IndividualModel/GoodnessFit.js @@ -8,14 +8,14 @@ import {ff} from "@/utils/formatters"; /* eslint-disable */ const hdr_c_normal = [ - "Dose", "Size", "Observed Mean", "Calculated Mean", "Estimated Mean", - "Observed SD", "Calculated SD", "Estimated SD", "Scaled Residual", + "Dose", "N", "Observed Mean", "Calculated Mean", "Estimated Mean", + "Observed SD", "Calculated SD", "Model MLE", "Scaled Residual", ], // zzz #30 hdr_c_lognormal = [ - "Dose", "Size", "Observed Mean", "Calculated Median", "Estimated Median", + "Dose", "N", "Observed Mean", "Calculated Median", "Estimated Median", "Observed SD", "Calculated GSD", "Estimated GSD", "Scaled Residual", ], - hdr_d = [ "Dose", "Size", "Observed", "Expected", "Estimated Probability", "Scaled Residual"]; + hdr_d = [ "Dose", "N", "Observed", "Expected", "Estimated Probability", "Scaled Residual"]; /* eslint-enable */ @observer @@ -66,6 +66,7 @@ class GoodnessFit extends Component { {ff(gof.calc_mean[i])} {ff(gof.est_mean[i])} {useFF ? ff(gof.obs_sd[i]) : gof.obs_sd[i]} + {/* zzz # 32 */} {ff(gof.calc_sd[i])} {ff(gof.est_sd[i])} {ff(gof.residual[i])} diff --git a/frontend/src/components/IndividualModel/ModelParameters.js b/frontend/src/components/IndividualModel/ModelParameters.js index 951ab64e..1ddd02f1 100644 --- a/frontend/src/components/IndividualModel/ModelParameters.js +++ b/frontend/src/components/IndividualModel/ModelParameters.js @@ -50,7 +50,11 @@ class ModelParameters extends Component { parameterFormatter(parameters.values[i]) )} - {bounded ? "NA" : parameterFormatter(parameters.se[i])} + + {bounded + ? "Not Reported" + : parameterFormatter(parameters.se[i])} + ); })} diff --git a/frontend/src/components/Output/Multitumor/GoodnessFit.js b/frontend/src/components/Output/Multitumor/GoodnessFit.js index b0a9a0ef..0c092e6d 100644 --- a/frontend/src/components/Output/Multitumor/GoodnessFit.js +++ b/frontend/src/components/Output/Multitumor/GoodnessFit.js @@ -8,14 +8,14 @@ import {ff} from "@/utils/formatters"; /* eslint-disable */ const hdr_c_normal = [ - "Dose", "Size", "Observed Mean", "Calculated Mean", "Estimated Mean", + "Dose", "N", "Observed Mean", "Calculated Mean", "Estimated Mean", "Observed SD", "Calculated SD", "Estimated SD", "Scaled Residual", ], // zzz #30 hdr_c_lognormal = [ - "Dose", "Size", "Observed Mean", "Calculated Median", "Estimated Median", + "Dose", "N", "Observed Mean", "Calculated Median", "Estimated Median", "Observed SD", "Calculated GSD", "Estimated GSD", "Scaled Residual", ], - hdr_d = [ "Dose", "Size", "Observed", "Expected", "Estimated Probability", "Scaled Residual"]; + hdr_d = [ "Dose", "N", "Observed", "Expected", "Estimated Probability", "Scaled Residual"]; /* eslint-enable */ @observer From 0e1762672cdc010f0eea47fd5e7f4ab607a04c88 Mon Sep 17 00:00:00 2001 From: hausman-gdit Date: Tue, 19 Dec 2023 09:41:19 -0500 Subject: [PATCH 04/29] 2, 6 --- frontend/src/components/Main/OptionsForm/OptionsFormList.js | 2 +- frontend/src/components/Output/BayesianResultTable.js | 4 ++-- frontend/src/components/Output/FrequentistResultTable.js | 4 ++-- frontend/src/components/Output/Multitumor/ResultTable.js | 4 ++-- 4 files changed, 7 insertions(+), 7 deletions(-) diff --git a/frontend/src/components/Main/OptionsForm/OptionsFormList.js b/frontend/src/components/Main/OptionsForm/OptionsFormList.js index 075cafea..fc93fe5e 100644 --- a/frontend/src/components/Main/OptionsForm/OptionsFormList.js +++ b/frontend/src/components/Main/OptionsForm/OptionsFormList.js @@ -37,7 +37,7 @@ class OptionsFormList extends Component { BMR Type BMRF Tail Probability - Confidence Level + Confidence Level (one-sided) Distribution +
Variance  diff --git a/frontend/src/components/Output/BayesianResultTable.js b/frontend/src/components/Output/BayesianResultTable.js index b71d7eaa..99a3aaaa 100644 --- a/frontend/src/components/Output/BayesianResultTable.js +++ b/frontend/src/components/Output/BayesianResultTable.js @@ -36,8 +36,8 @@ class BayesianResultTable extends Component { BMD BMDU Unnormalized Log Posterior Probability - Scaled Residual for Dose Group near BMD - Scaled Residual for Control Dose Group + Scaled Residual at Control + Scaled Residual near BMD diff --git a/frontend/src/components/Output/FrequentistResultTable.js b/frontend/src/components/Output/FrequentistResultTable.js index ae3a8bdc..ee120927 100644 --- a/frontend/src/components/Output/FrequentistResultTable.js +++ b/frontend/src/components/Output/FrequentistResultTable.js @@ -326,8 +326,8 @@ class FrequentistResultTable extends Component { P-Value AIC - Scaled Residual for Dose Group near BMD - Scaled Residual for Control Dose Group + Scaled Residual at Control + Scaled Residual near BMD {store.recommendationEnabled ? (