Nlog bmdu #67
Merged
Nlog bmdu #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/code_base/bmds_helper.cpp
Outdated
| @@ -9,6 +9,7 @@ | |||
| #include <ctime> | |||
| //#include <cmath> | |||
| #include <nlopt.hpp> | |||
| #include <functional> | |||
There was a problem hiding this comment.
removed. It was for something I had temporarily put in and then removed.
There was a problem hiding this comment.
can it be removed? it looks like it's still included
src/code_base/bmds_helper.cpp
Outdated
| @@ -4520,6 +4519,51 @@ void Nlogist_BMD(struct python_nested_analysis *pyAnal, struct python_nested_res | |||
| } | |||
| pyRes->bmdsRes.BMDL = BMDL; | |||
|
|
|||
|
|
|||
| //BMDU test | |||
There was a problem hiding this comment.
general comment - could this be written as an isolated function calcNlogisticBmdu(objData) instead of inline a really large function? it may make it easier to refactor in the future. This may not make sense in C++, apologies in advance.
There was a problem hiding this comment.
I refactored this. This was definitely needed, but I've been putting this off just to get the code running. There will be many other places that need it also. I'll circle back and do more refactoring if I have the time.
This was referenced Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added bmdu calc for nlogistic model