-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Product flows labeled as elementary flows in coal and natural gas extraction and processing #267
Comments
Residual OilThere are 37 entries of residual oil in the upstream_dict in eLCI (for ELCI_2020), split across coal and natural gas basins. For coal, the compartment is '31-33: Manufacturing/3241: Petroleum and Coal Products Manufacturing' and the ElementaryFlowPrimeContext is 'technosphere', while for gas, the compartment is 'Technosphere Flows/31-33: Manufacturing/3241: Petroleum and Coal Products Manufacturing' and the ElementaryFlowPrimeContext is 'emission'. After running olcaschema_genupstream_processes (upstream_dict.py), the gas versions are correctly labeled as PRODUCT_FLOWS, while the coal versions are relabeled as ELEMENTARY_FLOW with prepended "Elementary flows/emissions" to their category. And, since coal basins appear before gas basins in the dictionary, their version of the residual oil flow is read first, which is then referenced by natural gas, incorrectly labeled as elementary flow. |
One possible solution is to prepend the "Technosphere Flows/" to any coal basin flow categories with elementary flow prime context "technosphere". |
Alternatively, we can add "ElementaryFlowPrimeContext" to the |
Probably both of you solutions make sense, right? Agree that they should ultimately be placed under "Technosphere Flows." Adding an additional text against one of the columns also seems ok. Is there a reason we would choose on over the other or avoid doing both? Too belt and suspenders? |
Chose option 2. Seems to work. Ran it for 2020 and 2022, and the product
flows persist. Next problem is flow mapping, which seems to be all over the
place.
…On Mon, Nov 25, 2024, 16:17 Matt Jamieson ***@***.***> wrote:
Probably both of you solutions make sense, right? Agree that they should
ultimately be placed under "Technosphere Flows." Adding an additional text
against one of the columns also seems ok. Is there a reason we would choose
on over the other or avoid doing both? Too belt and suspenders?
—
Reply to this email directly, view it on GitHub
<#267 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AHCFB5MP2NWPFVFCPKGOSAL2COHVNAVCNFSM6AAAAABQ2RPBOKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIOJZGA2TIMJUGM>
.
You are receiving this because you were assigned.Message ID:
***@***.***>
|
There is a reasonable number of product flows turned elementary flows, which is causing provider issues when combined with other datasets.
![Screenshot 2024-10-29 at 15 01 27](https://private-user-images.githubusercontent.com/29642997/381271310-ebc2fffd-41f6-4c6a-98e7-69895873d80e.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk2MjI3MTcsIm5iZiI6MTczOTYyMjQxNywicGF0aCI6Ii8yOTY0Mjk5Ny8zODEyNzEzMTAtZWJjMmZmZmQtNDFmNi00YzZhLTk4ZTctNjk4OTU4NzNkODBlLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTUlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjE1VDEyMjY1N1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTgwYzZkMjkwZGNiOTAxOTBhZmMyZDliYTc1YmVlODJlZmMwNGRhYjc3YzIzMTkxMDUyNWZjN2I3NDBhMmFmNjYmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.163GoGll6q0jL7Nm-JkNLucSNcoo3ZVh8d3P4lGIs-U)
The text was updated successfully, but these errors were encountered: