Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Product flows labeled as elementary flows in coal and natural gas extraction and processing #267

Open
dt-woods opened this issue Oct 29, 2024 · 5 comments
Assignees
Labels
bug in v2 Issues marked for inclusion in version 2

Comments

@dt-woods
Copy link
Collaborator

There is a reasonable number of product flows turned elementary flows, which is causing provider issues when combined with other datasets.
Screenshot 2024-10-29 at 15 01 27

@dt-woods dt-woods added the bug label Oct 29, 2024
@dt-woods dt-woods self-assigned this Oct 29, 2024
dt-woods added a commit to KeyLogicLCA/ElectricityLCI that referenced this issue Nov 8, 2024
dt-woods added a commit to KeyLogicLCA/ElectricityLCI that referenced this issue Nov 8, 2024
@dt-woods
Copy link
Collaborator Author

Residual Oil

There are 37 entries of residual oil in the upstream_dict in eLCI (for ELCI_2020), split across coal and natural gas basins.

For coal, the compartment is '31-33: Manufacturing/3241: Petroleum and Coal Products Manufacturing' and the ElementaryFlowPrimeContext is 'technosphere', while for gas, the compartment is 'Technosphere Flows/31-33: Manufacturing/3241: Petroleum and Coal Products Manufacturing' and the ElementaryFlowPrimeContext is 'emission'.

After running olcaschema_genupstream_processes (upstream_dict.py), the gas versions are correctly labeled as PRODUCT_FLOWS, while the coal versions are relabeled as ELEMENTARY_FLOW with prepended "Elementary flows/emissions" to their category.

And, since coal basins appear before gas basins in the dictionary, their version of the residual oil flow is read first, which is then referenced by natural gas, incorrectly labeled as elementary flow.

@dt-woods
Copy link
Collaborator Author

dt-woods commented Nov 25, 2024

One possible solution is to prepend the "Technosphere Flows/" to any coal basin flow categories with elementary flow prime context "technosphere".

@dt-woods
Copy link
Collaborator Author

Alternatively, we can add "ElementaryFlowPrimeContext" to the merged_summary data frame and check its value.

dt-woods added a commit to KeyLogicLCA/ElectricityLCI that referenced this issue Nov 25, 2024
add cross-check against elementary flow prime context field in the dictionary writer
@m-jamieson
Copy link
Collaborator

Probably both of you solutions make sense, right? Agree that they should ultimately be placed under "Technosphere Flows." Adding an additional text against one of the columns also seems ok. Is there a reason we would choose on over the other or avoid doing both? Too belt and suspenders?

@dt-woods
Copy link
Collaborator Author

dt-woods commented Nov 26, 2024 via email

@dt-woods dt-woods added the in v2 Issues marked for inclusion in version 2 label Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug in v2 Issues marked for inclusion in version 2
Projects
None yet
Development

No branches or pull requests

2 participants