-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
32 if user inputs an invalid api key it should return the header titledetail when requesting #33
Conversation
…tests no longer relevant.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested a couple of endpoints with invalid api keys and got details in response.
get_genetox_summary_batch(DTXSID = c('DTXSID7020182'), API_key = 'wrong_key')
Error in get_genetox_summary_batch(DTXSID = c("DTXSID7020182"), API_key = "wrong_key") :
Please contact API admin for requesting a valid API key. Key wrong_key not found.
get_genetox_summary_batch(DTXSID = c('DTXSID7020182'), API_key = NULL)
Error in get_genetox_summary_batch(DTXSID = c("DTXSID7020182"), API_key = NULL) :
Every API call should pass assigned API key through custom http header or query parameter. Request is missing x-api-key.
get_genetox_summary_batch(DTXSID = c('DTXSID7020182'))
Error in get_genetox_summary_batch(DTXSID = c("DTXSID7020182")) :
Every API call should pass assigned API key through custom http header or query parameter. Request is missing x-api-key.
I think that the specific situation where the user does not input a key at all might need more guidance than the given response from the api, but maybe outside of the scope of this ticket. |
This closes #32 .