Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should LatLonDatum be in glob_att instead of instrument config files? #16

Open
dnowacki-usgs opened this issue Apr 25, 2018 · 4 comments

Comments

@dnowacki-usgs
Copy link
Member

This seems like something applicable to the mooring, not individual instruments. @emontgomery-usgs any thoughts on this?

@emontgomery-usgs
Copy link
Contributor

Yes, this sounds like a reasonable proposal. Adding the position Datum is new, so we're not spun up on how best to add it yet.

@dnowacki-usgs
Copy link
Member Author

Cool. Is the formatting of LatLonDatum finalized? As opposed to lat_lon_datum or something else? glob_att attributes generally seem to be in all caps, but it doesn't seem to be 100% consistent. Attributes in the .nc files seem to be mostly lowercase and separated by underscores. There doesn't seem to be a lot of CamelCase, however. Thoughts?

@emontgomery-usgs
Copy link
Contributor

emontgomery-usgs commented Apr 30, 2018 via email

@dnowacki-usgs
Copy link
Member Author

dnowacki-usgs commented May 1, 2018

OK, great. I think this can be implemented as follows:

  1. Add position_datum and elevation_datum as optional fields in global atts; add these to the examples in the docs. LatLonDatum will be deprecated in favor of position_datum.
  2. Assign datum attributes for lat, lon dimensions if position_datum exists.
  3. I'm not sure about elevation_datum being added to depth. Often (Grand Bay, at least) the instruments weren't surveyed in, so datum is local bed elevation. Also, I think with the variable being named "Depth" implies water-column depth and not water-surface elevation.. but you're the expert :). If you think adding elevation_datum as an attribute to depth (if it exists) is the right thing to do, I can implement that.
  4. I looked at the CF conventions, and they mostly deal with CRS values, which I suppose is more appropriate, but it's also another can of worms to deal with. They specify another variable, crs, with additional attributes that describe it. @rsignell-usgs thoughts on this?

Upon further review, I think that link really applies to grid mapping, which is something different. The coordinates don't really have datum information it would seem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants