Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pyDOE #336

Open
mathematicalmichael opened this issue May 26, 2019 · 5 comments
Open

pyDOE #336

mathematicalmichael opened this issue May 26, 2019 · 5 comments

Comments

@mathematicalmichael
Copy link
Collaborator

While trying to track down the issue for #335, I found that pyDOE has not been maintained in several years, with the author offering an apology a little over a year ago. There are a number of issues, including lack of python3 support, and more flexible random number generation, that have languished as PRs over the years.

One contributor started his own fork, which seems to be active. https://github.com/clicumu/pyDOE2

To this end, I suggest we discuss the merits of switching to pyDOE2 in favor of pyDOE, or consider removing it as a dependency altogether? Still unsure if this is at all related to the build errors on https://travis-ci.org/UT-CHG/BET/jobs/536822304 but it could be, since adaptiveSampling seems to be our problem.

@mathematicalmichael mathematicalmichael self-assigned this Jul 24, 2019
@mathematicalmichael
Copy link
Collaborator Author

@lcgraham do you have any thoughts on this?

@mathematicalmichael
Copy link
Collaborator Author

@smattis do you think this is worth trying out? more features, better maintenance (active community relative to what we depend on now, which is stale).

adaptiveSampling as mentioned in the original issue description has been fixed in #355, ignore that part, but ruling out pyDOE as the root of the error is what led me to stumble upon pyDOE2

@mathematicalmichael mathematicalmichael pinned this issue Sep 5, 2019
@smattis
Copy link
Contributor

smattis commented Nov 22, 2019

I am open to use pyDOE2. We really only use the Latin hypercube sampling from pyDOE now.

@smattis smattis added this to the Version 3 milestone Nov 22, 2019
@mathematicalmichael
Copy link
Collaborator Author

@smattis can we try to switch this out for v3?

@smattis
Copy link
Contributor

smattis commented Jun 2, 2020

We only use it for latin hypercube sampling and it is still working fine. If we were using more advanced features, then it may be worth the effort, but I don't see it at all as a priority.

@smattis smattis removed this from the Version 3 milestone Jun 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants