Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no mpi4py + mpirun for plotting #368

Open
mathematicalmichael opened this issue Dec 22, 2019 · 2 comments
Open

no mpi4py + mpirun for plotting #368

mathematicalmichael opened this issue Dec 22, 2019 · 2 comments

Comments

@mathematicalmichael
Copy link
Collaborator

this peculiar corner case happens to lead to failure of the plotDomains tests.
super low priority to fix, but pip install . does not handle mpi4py right now, and the test should skip but doesn't because technically it detects one processor.

To solve, I think we can use the __init__.py files to flag down whether we are faking MPI or not, and use that as the skip condition instead of processor count.

@smattis
Copy link
Contributor

smattis commented Dec 30, 2019

For which version of python is pip install mpi4py not working now? Was the the hosting server possibly just down?

@mathematicalmichael
Copy link
Collaborator Author

I never said it wasnt working. Just that in the event that it was forgotten to be installed (it’s not part of our requirements, technically, it has to be manually added), plotting tests detect one processor and fail to pass.

Our travis CI only tests in serial after mpi4py is uninstalled at the end. I’m saying that if we added an mpirun test as the final line there, it wouldn’t work, not for any functional reason, just a weird quirk.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants