Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding target to list should warn when coordinates mistyped #18

Open
ojf opened this issue Aug 30, 2017 · 4 comments
Open

Adding target to list should warn when coordinates mistyped #18

ojf opened this issue Aug 30, 2017 · 4 comments

Comments

@ojf
Copy link
Member

ojf commented Aug 30, 2017

When coordinates don't parse correctly Bifrost fails silently when the user tries to "add to list". There should be a warning, maybe a dialog box pops up and says "huh?"

@csayres
Copy link

csayres commented Jul 3, 2018

I would like to second this. This silent failure is pretty hard to identify (I've seen a few people get burned by this now in a short time). As an extension, I would suggest that Bifrost not only indicate a failure to parse input coords back to the user, but become more flexible. Eg allow ":" separated coords and " " separated coords. Furthermore the ability to enter coords in decimal degrees (not RA hours!) would be very nice as well...

@dougbrn
Copy link
Contributor

dougbrn commented Jul 6, 2018

To my knowledge, I believe I incorporated a fail warning when inputting coordinates incorrectly. Looking at the code, the Coordinates.inputcoordsorter includes a validity bool it tracks as it trys to parse input. If no valid format is found, it never flips the validity bool and triggers a pop-up box explaining the vaild coordinate formats. Also, based on that code it should handle ":" separated, " " separated, decimal degrees and hms dms. Its strange that people are getting a silent warning, maybe this function is being invoked incorrectly? I remember it was functional as of the 1.0 release.

@ojf
Copy link
Member Author

ojf commented Jul 6, 2018

I think you did too--but possibly only when using the telescope control tab, not in the Target List tab... Needs more characterization...

@dougbrn
Copy link
Contributor

dougbrn commented Jul 6, 2018

Hmm, well I see that the inputcoordsorter is invoked in the function bound to the add to list button on the Target list tab, so it should work for the Target List. If anything it wouldn't be implemented in the control tab rather than the Target list tab.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants