Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mailroom with dictionaries: remove reference to "letter" #46

Open
natasha-aleksandrova opened this issue Dec 27, 2020 · 3 comments
Open

Comments

@natasha-aleksandrova
Copy link
Collaborator

https://uwpce-pythoncert.github.io/ProgrammingInPython/exercises/mailroom/mailroom_with_dicts.html

confusing to students mention of letter (which used to be combined with files/letter feature)

Try to use a dict and the .format() method to produce the letter as one big template, rather than building up a big string that produces the letter in parts.

remove that requirement ?

@PythonCHB
Copy link
Contributor

I think learning how to use ** with .format is still a good idea.

And I don't understand the confusion -- this isn't changing / adding an features, simply suggesting a way to use template, .format() and a dict to do the same thing.

But if you can think of a way to make it more clear, sure.

@natasha-aleksandrova
Copy link
Collaborator Author

the term "letter" isn't something that's a feature until later so the confusion is the terminology used -- "produce a letter" but we don't ask to produce a letter feature until later.

"send letters to all donors" menu option is added later on now.

@PythonCHB
Copy link
Contributor

ahh -- good catch, I lost track of what's when. I'll try to update that soon.

Odd that I didn't have any students complain about this in my class ....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants