Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More notes on design of OO mailroom #51

Open
PythonCHB opened this issue Dec 31, 2020 · 0 comments
Open

More notes on design of OO mailroom #51

PythonCHB opened this issue Dec 31, 2020 · 0 comments

Comments

@PythonCHB
Copy link
Contributor

I found a few students would write a DonorCollection class, but have it be a wrapper around their previous structure, without "proper" encapsulation.

that is, the class would be a namespace for the all their previous functions that worked with the donors structure, but kept the structure itself separate.

A little more discussion / clarity on the design might help this.

and a warning against:

def __init__(self, donors):
    self.donors = donors

where donors is the original donors structure, and there is no copy made.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant