Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Units in HAM.HeatAndMoistureTransport #23

Open
thorade opened this issue Nov 19, 2015 · 1 comment
Open

Units in HAM.HeatAndMoistureTransport #23

thorade opened this issue Nov 19, 2015 · 1 comment
Assignees
Labels

Comments

@thorade
Copy link
Contributor

thorade commented Nov 19, 2015

Advanced.PedanticModelica:=true;
checkModel("BuildingSystems.HAM.HeatAndMoistureTransport");

Looks like there are some units wrong.

@jmoeckel
Copy link
Contributor

See e.g. BuildingSystems.HAM.HeatAndMoistureTransport.HeatAndMoistureTransport1D equation for Moisture flow rate at side 1

 moisturePort_x1.m_flow =
    CMd * (phi_x1 *  BuildingSystems.Utilities.Psychrometrics.Functions.saturationPressure(heatPort_x1.T)
     - phi * BuildingSystems.Utilities.Psychrometrics.Functions.saturationPressure(T))
     + CLt * (phi_x1 - phi);

Expressed in units, we have:

[kg/s] = [kg/(s.Pa)]*[1]*[Pa] + [kg/(s.m)]*[1]
         = [kg/s] + [kg/(s.m)] 

As the unit for a mass flow is obviously kg/s, either unit of Types.CoefficientOfLiquidTransport ([kg/(s.m)]) is wrong or this equation has to be multiplied with a mass (if so, this error has to be corrected at many places).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants