Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

slow and broken unit tests #78

Open
thorade opened this issue May 13, 2017 · 2 comments
Open

slow and broken unit tests #78

thorade opened this issue May 13, 2017 · 2 comments
Assignees
@thorade @nytschgeusen @ainderfurth @jmoeckel

Comments

@thorade
Copy link
Contributor

thorade commented May 13, 2017 •
edited
Loading

The tests listed in the file
Resources/Scripts/skipUnitTestList.txt
take very long to simulate or are broken (i.e. BuildingsPy cannot parse them).
Could everybody please check whether you created one of the mos scripts and try to fix it?
If no easy fix is available, just leave it on the skip list.
thorade added a commit that referenced this issue May 13, 2017
@thorade
more problematic unit tests, see #78
f68300e
This was referenced May 13, 2017
Closed
Merged
@thorade thorade closed this as completed Jul 31, 2017
@thorade thorade reopened this Nov 2, 2017
@thorade thorade assigned thorade, nytschgeusen and jmoeckel and unassigned carlesRT Nov 2, 2017
@thorade thorade mentioned this issue Nov 2, 2017
Closed
@thorade
Copy link
Contributor Author

thorade commented Nov 2, 2017 •
edited
Loading

Reopening:
We should change all examples (except the ones in Applications) so that they are fast (below 10 seconds) and results can be read by BuildingsPy.

OpenModelica continuous testing aborts simulation when it takes more than 480 seconds.

@thorade
Copy link
Contributor Author

thorade commented Dec 5, 2017

For test that are too slow, additional event and integrator analysis might help to find the bottlenecks.
The two screenshots below explain how to find the event and numerics log.

Step 1: Turn on the logging:

debug_event_integrator

Step 2: In the variable browser, right-click on the top level node:

analyze_numerics

thorade added a commit that referenced this issue Dec 7, 2017
@thorade
ignore diagnostics and eventlog files
1c752b8 
see #78 (comment)
@thorade thorade mentioned this issue Dec 7, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thorade thorade

@nytschgeusen nytschgeusen

@ainderfurth ainderfurth

@jmoeckel jmoeckel

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@thorade @nytschgeusen @ainderfurth @jmoeckel @carlesRT