Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cyclic_conv1d_alt different result #1

Open
wallneradam opened this issue Mar 2, 2019 · 1 comment
Open

cyclic_conv1d_alt different result #1

wallneradam opened this issue Mar 2, 2019 · 1 comment

Comments

@wallneradam
Copy link

Hi,

I'm playing with your library and tried to get the same results as PyWavelets' dwt/idwt functions. I got totally different ones. I found that you have 2 version of cyclic_conv1d, and cyclic_conv1d_alt is used in dwt1d and idwt1d. If I change it to the normal (not "_alt" suffixed version), I get the same results as PyWavelets.

My question is, what is this "_alt" version good for, why it is used instead of the "normal" one? And is it normal to get different results from them?

Thank you for your work on this library, it is very useful!

@mathialo
Copy link
Contributor

Hello!

They are intended to be the same, the _alt version was implemented as an easier-to-maintain alternative following an easier idea for periodic extensions for the convolutions, so what you have found is definitely a bug.

Could you post details on your input and how you achieve the different results? That could be very useful for debugging.

Thanks a lot for your feedback!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants