Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parser fails to recognize '12p' #17

Open
joxl opened this issue Apr 8, 2022 · 2 comments
Open

Parser fails to recognize '12p' #17

joxl opened this issue Apr 8, 2022 · 2 comments

Comments

@joxl
Copy link

joxl commented Apr 8, 2022 •
edited
Loading

System details

  • OS: Ubuntu 21.10
  • Desktop: Ubuntu on Xorg
  • Version (ulauncher-timer): 4262fc2 (2020-11-3)

Steps to reproduce

  1. Invoke Ulauncher Timer extension
  2. Enter time 12p

Observe

Action shows "Incorrect request".
image

Expected

Action shows "Set timer for 12p".
@gornostal
Copy link
Member

What's 12p?
I assume 12pm. The timer extension expects time interval not time value in that position.

@joxl
Copy link
Author

joxl commented May 2, 2022 •
edited
Loading

@gornostal Yes, sorry for not making that clearer. The letters a and p are short for am and pm (either long/short form is accepted). These suffixes work as expected with the exception of 12p and 12pm. Here's an example showing the (accepted) value 11p:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gornostal @joxl