Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Time formatting: why harcoded 12h-format ? #20

Open
brunetton opened this issue Mar 24, 2023 · 1 comment · May be fixed by #23
Open

Time formatting: why harcoded 12h-format ? #20

brunetton opened this issue Mar 24, 2023 · 1 comment · May be fixed by #23

Comments

@brunetton
Copy link
Contributor

brunetton commented Mar 24, 2023

Hi. First of all thanks for this little piece of software; I'm using it with joy :)

One minor thing: I noticed that time format is 12h-format. Is there any reason for that ? I'm a French user, and here we're used to read "14:00" for 2PM.

Changing the date representation in Timer.description() from '%-I:%M %p' to '%-H:%M %p' solves the problem for me.

I think we Timer should refer to system for time format (en_US.UTF-8 will result is 12-hour format, and fr_FR.UTF-8 in 24h-format)

What do you think about it ?

Thanks

@gornostal
Copy link
Member

I agree that it would be good to support 24h format.
The reason for the AM/PM to be there was that someone contributed a PR with only that format support.
I'm not actively supporting this extension. Feel free to submit a PR with 24h format support if you'd like.

brunetton added a commit to brunetton/ulauncher-timer that referenced this issue Mar 25, 2023
This was referenced Mar 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants