Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BetterGrassify does not appear with Sodium [1.21.4] #42

Closed
TimmyChips opened this issue Dec 8, 2024 · 7 comments
Closed

BetterGrassify does not appear with Sodium [1.21.4] #42

TimmyChips opened this issue Dec 8, 2024 · 7 comments
Labels
bug Something isn't working

Comments

@TimmyChips
Copy link

TimmyChips commented Dec 8, 2024

Describe your issue

BetterGrassify works flawlessly without Sodium, but when adding Sodium, the grass does not appear. The new settings inside of Sodium appear under the video settings, but something about Sodium is overwriting the rendering of blocks from BetterGrassify.

Moss Carpet and Snow do extend to other blocks, so that does work.

Mod version

1.4.0+fabric.1.21.4

Launcher

Fabric

Additional context

Only line related to the mod I can see in latest.log is [12:44:59] [Render thread/INFO]: Successfully loaded image 'bettergrass:textures/images/bettergrassmode.webp', so it does seem to load the texture fine.

@TimmyChips TimmyChips added the bug Something isn't working label Dec 8, 2024
@UltimatChamp
Copy link
Owner

UltimatChamp commented Dec 9, 2024

I don't think there are any significant changes in the mod in 1.21.4, except for using Fabric's Model Loading API instead of a mixin into vanilla directly (which shouldn't affect Sodium). Sodium's FRAPI's emitBlockQuads implementation might be broken. You should report to them instead. (Not closing this until this issue is fixed either from Sodium's side, which seems highly likely to me, or the mod's side)

@UltimatChamp UltimatChamp added the question Further information is requested label Dec 9, 2024
@UltimatChamp UltimatChamp pinned this issue Dec 9, 2024
@UltimatChamp
Copy link
Owner

Only line related to the mod I can see in latest.log is [12:44:59] [Render thread/INFO]: Successfully loaded image 'bettergrass:textures/images/bettergrassmode.webp', so it does seem to load the texture fine.

This is just an image/preview for the YACL config screen.

@ImGRUI
Copy link

ImGRUI commented Dec 9, 2024

I think this is related to this bug
image

@UltimatChamp
Copy link
Owner

So, it does seem to be a Sodium bug.

image

image

@TimmyChips
Copy link
Author

So, it does seem to be a Sodium bug.

Ah, that's super unfortunate to hear. This mod is phenomenal so hopefully the Sodium team manage to get a fix going to fix the block rendering!

@UltimatChamp
Copy link
Owner

UltimatChamp commented Dec 23, 2024

Seems to be fixed with CaffeineMC/sodium@a40937b!

@UltimatChamp
Copy link
Owner

Fixed with Sodium 0.6.6!

@UltimatChamp UltimatChamp removed the question Further information is requested label Dec 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants