Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Per-key tooltip storage #788

Open
mondalaci opened this issue Jun 27, 2024 · 3 comments
Open

Per-key tooltip storage #788

mondalaci opened this issue Jun 27, 2024 · 3 comments

Comments

@mondalaci
Copy link
Member

This issue is the firmware side of UltimateHackingKeyboard/agent#2289

@kareltucek Can we use the most significant bit of key_action_t.type to store the hasNote flag? The note string would be stored as the last element of key_action_t. I'm asking to ensure I'm not missing anything.

@kareltucek
Copy link
Collaborator

kareltucek commented Jun 27, 2024

Can we use the most significant bit of key_action_t.type to store the hasNote flag?

I think yes.

The note string would be stored as the last element of key_action_t.

We don't want to load it in firmware (into key_action_t), do we?

(I don't want to waste another precious 2*12*4*65 bytes on this.)

@mondalaci
Copy link
Member Author

I only mean the note string to be serialized as suggested and displayed by Agent. But we wouldn't store it in the RAM. The config parser could also disregard the hasNote bit when saving key actions in the RAM, so branching based on key_action_t.type would be faster.

@kareltucek
Copy link
Collaborator

Then we are on the same page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants