Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#AUDIO compliance with USDX Format Specification 1.1.0 #503

Open
ScallyGames opened this issue Nov 10, 2024 · 1 comment
Open

#AUDIO compliance with USDX Format Specification 1.1.0 #503

ScallyGames opened this issue Nov 10, 2024 · 1 comment

Comments

@ScallyGames
Copy link

Issue type: Bug report

Actual behaviour

According to https://usdx.eu/format/#specs the #MP3 section is deprecated and should be replaced with #AUDIO
However when providing txt files with only #AUDIO and no #MP3 they don't show up in the play section but also don't throw any warnings in Settings->Songs.

Expected behaviour

It should just accept the #AUDIO tag instead of the #MP3 tag.
Alternatively it should at least throw up some warning/error in the Settings->Songs section.
As far as I can tell the ideal solution would be to accept the #AUDIO tag and even throw a deprecation warning in Settings->Songs that #MP3 is deprecated and should be replaced with #AUDIO seeing that it's supposed to be removed in 2025.

Steps to reproduce

  • Reproducible (mark with x): [x] always, [ ] sometimes
  1. Add song folder with only #AUDIO and no #MP3 to the songs folder
  2. Navigate to the song selection menu
  3. Verify song isn't there
  4. Change #AUDIO to #MP3 in the .txt file
  5. Repeat and verify it shows up

Details

I'm a bit confused that the specs page lists USP as a supported app for the AUDIO tag but at least for me it didn't work. There might be additional factors involved if this issue were to be specific to me.

Turns out in the log file it actually logged an error about MP3 being a required field.

  • Game version: 0.9.0 (f56906a)
  • Operating System and version: Archlinux
  • Song details, if applicable (e.g. audio and video file format): Audio as mp3, Video as mp4, all in the same folder
  • Log: (truncated for privacy) UltraStar Play Truncated.log
@achimmihca
Copy link
Collaborator

The current release build v0.9.0 is heavily outdated.
The current master implements the new USDX format spec. So should be fixed with next release.

Melody Mania also already implements this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants