Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alert Profiles does not validate IP addresses in filter expressions #1876

Closed
lunkwill42 opened this issue Feb 28, 2019 · 1 comment · Fixed by #2667
Closed

Alert Profiles does not validate IP addresses in filter expressions #1876

lunkwill42 opened this issue Feb 28, 2019 · 1 comment · Fixed by #2667
Assignees
Labels

Comments

@lunkwill42
Copy link
Member

The Alert Profiles UI does not validate the input of IP address filters, meaning any string can be entered as an IP address value.

The Alert Engine takes for granted that the filter value is semantically correct, and uses it directly when querying PostgreSQL, which results in PostgreSQL errors that are logged like this (every 30 seconds into eternity or until the filter is no longer present in a profile, whichever comes first):

2019-02-28 11:46:46,266 [ERROR] [nav.alertengine] Database error, closing the DB connection just in case:
invalid input syntax for type inet: "shit"
LINE 1: ...L AND "alertq"."alertqid" = 211352 AND (netbox.ip = 'shit'))
@johannaengland
Copy link
Contributor

Closed by #2667

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants