Uncrispify StyleFormTwo in styleguide
#3181
Conversation
johannaengland
requested review from
lunkwill42,
hmpf,
stveit and
podliashanyk
🦙 MegaLinter status: ✅ SUCCESS
See detailed report in MegaLinter reports MegaLinter is graciously provided by |
Test results 9 files 9 suites 8m 20s ⏱️ Results for commit 840f11b. ♻️ This comment has been updated with latest results. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3181 +/- ##
=======================================
Coverage 60.39% 60.39%
=======================================
Files 605 605
Lines 43705 43701 -4
Branches 48 48
=======================================
- Hits 26394 26393 -1
+ Misses 17299 17296 -3
Partials 12 12 ☔ View full report in Codecov by Sentry. |
johannaengland
force-pushed
the
refactor/uncrispify-style-form-two-style-guide
branch
from
4c6c3f7 to
9f657f1
Compare
There was a problem hiding this comment.
Nicely done!
I think it looks better than the original. I consider the broken fieldset in the original implementation a bug which is now fixed 🙂:
There is one functional difference though. HTML attribute method in form1 in now empty (which de facto means method='get') while in the original it was method='post'. I doesn't make practical difference though since 1. there is no submit button 2. because the "Forms" section in styleguide is for showcasing the looks and not the functionality.
Yes, I noticed that as well and I agree |
johannaengland
force-pushed
the
refactor/uncrispify-style-form-two-style-guide
branch
from
9f657f1 to
840f11b
Compare
|
johannaengland
deleted the
refactor/uncrispify-style-form-two-style-guide
branch
Closes #3179.
Url: http://localhost/styleguide/
It looks slightly different now, but I think this is okay given it's the styleguide and this can be adapted in #3180.