Abort SNMP-based ARP collection if ARP records seem to have been collected earlier in the same ipdevpoll job run #3254
Conversation
🦙 MegaLinter status: ✅ SUCCESS
See detailed report in MegaLinter reports MegaLinter is graciously provided by |
Test results 9 files 9 suites 8m 15s ⏱️ Results for commit f238f97. ♻️ This comment has been updated with latest results. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3254 +/- ##
==========================================
+ Coverage 60.54% 60.58% +0.03%
==========================================
Files 606 606
Lines 43723 43733 +10
Branches 48 48
==========================================
+ Hits 26474 26494 +20
+ Misses 17237 17227 -10
Partials 12 12 ☔ View full report in Codecov by Sentry. |
This makes the paloaltoarp plugin less dependent on having its base class (`Arp`) run first to update the prefix cache.
lunkwill42
force-pushed
the
bugfix/paloalto-arp-priority
branch
from
b04a11e to
5ac2bef
Compare
|
Found a bug myself, in the way the extracted cache function was being called. Force-pushed changes since no-one had reviewed yet. |
This ensures that the SNMP-based `arp` plugin exits early if it appears that some other plugin has already collected Arp records before it. This makes the `arp` plugin a sort of fallback in a scenario where vendor specific ARP collection plugins run first, rather than having multiple ARP plugin step on each others toes.
This also removes the premature 5.12 heading: The already existing `Unreleased` section takes it place, and will be updated as standard procedure on the next feature release.
lunkwill42
force-pushed
the
bugfix/paloalto-arp-priority
branch
from
5ac2bef to
f238f97
Compare
|
Fixes #3252 by the following strategy:
arpplugin a sort of "fallback" plugin: If it detects that ARP mappings have already been added to the container registry, it skips all SNMP-based processing of ARP, to avoid stepping on some other plugin's toes.ip2macipdevpoll job: Vendor specific plugins likepaloaltoarpshould run first, and if they they either declined to run, or didn't find anything, it cannot hurt that SNMP-based collection is run.