Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Excessive data passed to reactorCallback #174

Open
wjmelements opened this issue Jul 17, 2023 · 1 comment
Open

Excessive data passed to reactorCallback #174

wjmelements opened this issue Jul 17, 2023 · 1 comment

Comments

@wjmelements
Copy link

wjmelements commented Jul 17, 2023

The following information is not useful to an IReactorCallback implementation, and can be passed as fillData if actually necessary:

  • ResolvedOrder.OrderInfo (all fields)
  • ResolvedOrder.sig
  • ResolvedOrder.hash
  • ResolvedOrder.InputToken.maxAmount

Reducing the data passed to the function will reduce the memory footprint of the execution scope and therefore the gas.

[edit: added to list of unnecessary fields]

@wjmelements
Copy link
Author

I suspect ResolvedOrder.InputToken.token and ResolvedOrder.InputToken.amount are also usually unnecessary for most reactorCallback but they at least may potentially be useful to some, unlike the other fields mentioned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant