You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Bug Description
On info.uniswap.org, the "Search pools or tokens" box cannot be used to to find projects whose names begin with 0x.
Steps to Reproduce
Go to info.uniswap.org.
Enter the "Search pools or tokens" box.
Type "0xbtc".
Confirm "No results".
Clear the search box.
Type "xbtc".
Confirm that there are results.
Expected Behavior
Typing "0xbtc" should show results that contain references to the project whose ticker is 0xBTC.
Additional Context https://github.com/Uniswap/v3-info/blob/master/src/data/search/index.ts#L216
Checking whether the first characters of a string are 0x seems like too imprecise of a check for whether a value is an Ethereum address. If the intent of the code is to avoid regex matches, could the isAddress check be extended to include a check of the length of the value?
The text was updated successfully, but these errors were encountered:
Bug Description
On info.uniswap.org, the "Search pools or tokens" box cannot be used to to find projects whose names begin with
0x
.Steps to Reproduce
Expected Behavior
Typing "0xbtc" should show results that contain references to the project whose ticker is 0xBTC.
Additional Context
https://github.com/Uniswap/v3-info/blob/master/src/data/search/index.ts#L216
Checking whether the first characters of a string are
0x
seems like too imprecise of a check for whether a value is an Ethereum address. If the intent of the code is to avoid regex matches, could theisAddress
check be extended to include a check of the length of the value?The text was updated successfully, but these errors were encountered: