Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Event for dynamic fee update #920

Open
kaber2 opened this issue Nov 20, 2024 · 2 comments
Open

Event for dynamic fee update #920

kaber2 opened this issue Nov 20, 2024 · 2 comments
Labels

Comments

@kaber2
Copy link

kaber2 commented Nov 20, 2024

Component

General design optimization (improving efficiency, cleanliness, or developer experience)

Describe the suggested feature and problem it solves.

While implementing support for UniswapV4 in my software, I noticed there is no event for dynamic fee updates. I realize that hooks can override fees anyways, which will already make fully supporting UniswapV4 rather complicated. It would be appreciated if at least dynamic fees can be handled through events.

Describe the desired implementation.

Emit event in updateDynamicLPFee().

Describe alternatives.

No response

Additional context.

No response

@kaber2 kaber2 added the triage label Nov 20, 2024
Copy link

linear bot commented Nov 20, 2024

@kaber2
Copy link
Author

kaber2 commented Nov 22, 2024

PROTO-686 Event for dynamic fee update

I don't know what this is supposed to be, but it leads to a registration that is followed by pretty much nothing. Please stop spamming my report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant