fix: Allow UDP/DTLS connections when working in the editor with WebGL #2695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our check for
#if UNITY_WEBGLthat forced the usage of theWebSocketNetworkInterfacewould also apply in the editor. But in the editor, it's fine to use UDP/DTLS even if your build target is WebGL. It's not particularly useful to do that, but it could be used for debugging purposes (e.g. trying to assess whether an issue is caused by WebSockets or not). Enabling that workflow only required modifying the check to also verify we're not in the editor.Changelog
UnityTransportwould attempt to establish WebSocket connections even if using UDP/DTLS Relay allocations when the build target was WebGL. This only applied to working in the editor since UDP/DTLS can't work in the browser.Testing and Documentation