Fixes for admin and resident side nav, helpful link card consistency, and unfavoriting a helpful link per issues #658, #678, and #692 #693
+155
−130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…add pager feature to helpful links page per UnlockedLabs#678
jtucholski
approved these changes
Jan 29, 2025
|
Looks good, brought it down locally and compared to staging as I went over the code. 💯 🥇 🏆 |
|
@carddev81 Looks good. Once you resolve the issue in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
NOTE: In screenshot below for ticket #658, I highlighted an icon, confirming if this icon is correct for 'Trending Content'?)
UI: Updates to Side Navigation for Administrator and Resident #658
UI/UX: Helpful Link card UI isn't consistent with Library Card Component #678
Unable to unfavorite a helpful link #692
FIX: Update Sidebar Icons for "Learning Path" and "Trending Content" #667
Related issues: closes UI: Updates to Side Navigation for Administrator and Resident #658, closes FIX: Update Sidebar Icons for "Learning Path" and "Trending Content" #667, closes UI/UX: Helpful Link card UI isn't consistent with Library Card Component #678, closes Trending Content > Helpful link card text doesn't match Featured Content card text #682, closes Unable to unfavorite a helpful link #692.
Screenshot(s)
#658 Admin
#658 Student (note the highlighted icon---should this icon be different?)
#678
#692
#667
