Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch to file_out=None for mkvpropedit #419

Merged
merged 2 commits into from
Aug 29, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions source/mkvpropedit/changelog.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@

**<span style="color:#56adda">0.0.3</span>**

- Set file_out to None instead of creating a hardlinked copy as the file_out

**<span style="color:#56adda">0.0.2</span>**

- Fix invalid plugin tags
Expand Down
2 changes: 1 addition & 1 deletion source/mkvpropedit/info.json
Original file line number Diff line number Diff line change
Expand Up @@ -9,5 +9,5 @@
"on_worker_process": 99
},
"tags": "command, mkv, tweaks",
"version": "0.0.2"
"version": "0.0.3"
}
10 changes: 5 additions & 5 deletions source/mkvpropedit/plugin.py
Original file line number Diff line number Diff line change
Expand Up @@ -144,9 +144,6 @@ def create_xml_tags_file():
tree.write(tags_filename)

def process_file():
# Copy the input file to the output file
os.link(data.get('file_in'), data.get('file_out'))

# Start off with calling mkvpropedit
command = ['mkvpropedit']

Expand All @@ -162,10 +159,10 @@ def process_file():
command.extend(other_args.split())

# Pass in working file name
command.append(data.get('file_out'))
command.append(data.get('file_in'))

# Execute the command
if command == ['mkvpropedit', data.get('file_out')]:
if command == ['mkvpropedit', data.get('file_in')]:
logger.error("No arguments provided for mkvpropedit, skipping...")
return

Expand All @@ -180,4 +177,7 @@ def process_file():

data['command_progress_parser'] = parse_progress

# Set the output file to None since mkvpropedit does not create a new file
data['file_out'] = None

return data
Loading