Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom ffmpeg options not being applied correctly #516

Open
GoldieLocks89 opened this issue Jan 6, 2025 · 1 comment
Open

Custom ffmpeg options not being applied correctly #516

GoldieLocks89 opened this issue Jan 6, 2025 · 1 comment

Comments

@GoldieLocks89
Copy link

Have you read the Code of Conduct? By filing an Issue, you are expected
to comply with it, including treating everyone with respect:

Remember that these are some guidelines, use your best judgement.

Description

I'm attempting to have the h264 encoder use hardware acceleration instead of CPU but it doesn't appear that the ffmpeg options are being applied correctly.

The help guide for the plugin states:
image

MAIN OPTIONS - After the default generic options.
ffmpeg
-hide_banner
-loglevel info

-i /path/to/input/video.mkv \

So I have added the option I guess I need to the main options section:

image

Yet in the logs that follow, it appears to be inserting this argument after the input video:

ffmpeg -hide_banner -loglevel info -i '/library/Films_Kids/SnippedName.mkv' -hwaccel qsv -strict -2 -max_muxing_queue_size 4096 -map 0:v:0 -map 0:a:0 -c:v:0 libx264 -c:a:0 copy -y '/tmp/unmanic/unmanic_file_conversion-lsofs-1736171703/SnippedName-lsofs-1736171703-WORKING-1-1.mp4'

Steps to Reproduce

  1. Apply some Main Options to the Video Encoder H264 - libx264 (CPU) plugin
  2. Run the plugin and observe the logs

Expected behavior: The arguments to be inserted before the input file path

Actual behaviour: The arguments are inserted after the input file path

Reproduces how often: 100%

Versions

The version can be found at the footer of the WebUI. Also, please include the OS details and what version you are running
(e.g. cat /etc/os-release).
Version: [0.2.8+925008e+dirty]
Docker on Unraid

Installation Method Used

Manually installed and run or run through Docker?
Docker on Unraid

Additional Information

Any additional information, configuration or data that might be necessary to
reproduce the issue.

@jecorn
Copy link

jecorn commented Jan 8, 2025

I also see this in #491 . It's a pretty fundamental mixup between docs and behavior, which prevents core functionality. Would be great to get this addressed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants