Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Hold] Platform: Supported file types #352

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[Hold] Platform: Supported file types #352

wants to merge 1 commit into from

Conversation

Paul-Cornell
Copy link
Collaborator

@Paul-Cornell Paul-Cornell commented Nov 26, 2024 •
edited
Loading

@Paul-Cornell Paul-Cornell marked this pull request as ready for review November 26, 2024 00:56
MKhalusova
MKhalusova reviewed Nov 26, 2024
View reviewed changes
Copy link
Collaborator

@MKhalusova MKhalusova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the PR in the product repo that shows that we have added support for these file types?

MKhalusova
MKhalusova approved these changes Nov 26, 2024
View reviewed changes
Copy link
Collaborator

@MKhalusova MKhalusova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved conditioned on @cmscmadd 's test result.

@Paul-Cornell Paul-Cornell changed the title Platform: Supported file types [Hold] Platform: Supported file types Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MKhalusova MKhalusova MKhalusova approved these changes

@cmscmadd cmscmadd Awaiting requested review from cmscmadd

@ninalopatina ninalopatina Awaiting requested review from ninalopatina

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Paul-Cornell @MKhalusova