Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can see through a ceiling from "dome" #19

Open
slipher opened this issue Nov 11, 2024 · 9 comments
Open

Can see through a ceiling from "dome" #19

slipher opened this issue Nov 11, 2024 · 9 comments

Comments

@slipher
Copy link
Contributor

slipher commented Nov 11, 2024

unvanquished_2024-11-10_225228_000

From this location there is, geometrically speaking, a line of sight to many other rooms, as can be seen by turning on the material system. But the other ones are concealed by the skybox while this one isn't.

@slipher
Copy link
Contributor Author

slipher commented Nov 11, 2024

It's relying on vis apparently. With r_novis you can see a ton of stuff.

@sweet235
Copy link
Contributor

sweet235 commented Nov 11, 2024

It's relying on vis

There are other maps doing this as well. One example is https://github.com/Masmblr/map-jota_src at 35 -1698 95 90 3 (this map is superseded by https://github.com/Masmblr/map-jota_src.dpkdir, which does not do this).

One could argue that the parts hidden by the sky are map deficiencies. After all, this must not happen in euclidean space. atcs, for example, erects two huge structures mainly for this reason. Nevertheless, I have wondered on occasion: is there a method to hide such rooms in some shader? Or can cleverly placed vis hints do it?

If we cannot find any method to make this room invisible, I see no other way than to either lower the height of the dome's ceiling, or to add nontransparent surfaces on top of the room we can look into.

@illwieckz
Copy link
Member

Many maps suffer from this, uncreation has some of it (obvious), arachnid2 too (hard to spot). This is due to the skybox mechanism being as fast as it is naïve: the game first paints the sky, then paints anything else (even if the sky surface is in front of it). This is true since forever, tremulous/quake3 suffered from this. Of course it's a map bug since there can't be an hidden room behind the sky in real life, without an actual wall hidingit.

This feature by @VReaperV is meant to fix that:

See also:

@illwieckz
Copy link
Member

But the other ones are concealed by the skybox while this one isn't.

It's relying on vis apparently. With r_novis you can see a ton of stuff.

Indeed, there is no such thing as skybox concealing things, things not rendered are just things excluded by the vis.

@Viech
Copy link
Member

Viech commented Nov 11, 2024

Could it have been the case in the past that the skybox was hiding the geometry behind it? I was certainly up in the dome many times during testing and I never noticed this.

One could argue that the parts hidden by the sky are map deficiencies. After all, this must not happen in euclidean space. atcs, for example, erects two huge structures mainly for this reason.

fwiw, I considered there to be some (desert) landscape right around the dome and the hangar exit, with everything else being underground.

@sweet235
Copy link
Contributor

I considered there to be some (desert) landscape right around the dome and the hangar exit

That would probably be the easiest fix right now. Put a sand patch mesh there and call it a day.

@slipher
Copy link
Contributor Author

slipher commented Nov 11, 2024

I checked Unvanquished 0.49 and the bug was already there, so this was not caused by recent sky changes.

@illwieckz
Copy link
Member

illwieckz commented Nov 11, 2024

Yes, it's super old, there are old threads around about it:

2012-09-12 illwieckz: At one point you can see through the ceiling: https://postimg.cc/CnyLPnTM
2012-09-14 Viech: The first bug isn't my fault, it's based on the way the engine handles skyboxes. Whatever gets rendered from your perspective (which is not only what you can see but usually slightly more) can be seen through the skybox. I'd need to build an outside area that lays before the visible regions.
-- https://forum.tremulous.net/index.php?topic=16797.msg234786#msg234786

map-parpax-beta3-bug

For archaeologist, it was linked there: Unvanquished/Unvanquished#112
At the time I was saying the new renderer could not run on my computer. 🤭️

@illwieckz
Copy link
Member

illwieckz commented Nov 11, 2024

Funny to see that on the exact same hardware, the new renderer is now able to render the map, a bit slower on same resolution though:

unvanquished_2024-11-12_002533_000

With lower resolution it's more acceptable:

unvanquished_2024-11-12_002621_000

The good news is that the elevator (the vertical lines on the right on screenshot from 2012) is now out of vis thanks to some vis optimizations having been done in the map since that time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants