Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wally search should be useable without wally.toml in directory #139

Open
Barocena opened this issue Jun 7, 2023 · 3 comments
Open

Wally search should be useable without wally.toml in directory #139

Barocena opened this issue Jun 7, 2023 · 3 comments

Comments

@Barocena
Copy link

Barocena commented Jun 7, 2023

currently Wally search command does not work if the terminal is not in project directory

it would be a cool QoL change if it is possible

@u-train
Copy link
Contributor

u-train commented Jun 30, 2023

my 2c:

It's a technical reason, but to search, Wally needs to know what registry to search in. Right now, your manifest file would specify that, hence the dependence.

But, we can assume that people will be searching in Uplift's registry 99% of the time. Could also provide an optional argument in the rare case someone wants to search in some alternative registry.

Is it worth adding? Especially because there is a website to search for packages.

@magnalite
Copy link
Member

Yeah I'm really unsure what to do about this one. In general we should avoid any assumptions about which registry the user wants to use, this is why this currently doesn't work. Additionally, as u-train pointed out, there is also the website which provides an easy way to search the pubic registry already.

That said, if a blind search is asked for then it is exceedingly likely the user just wants to search the public registry so this would be a nice and easy QoL change. We can bench this for later but I think we should decide on a final outcome before we hit 1.0.0.

@LastTalon
Copy link
Contributor

I think having a clear order of something like command line argument -> environment variable -> manifest file -> sensible default makes a lot of sense. If you're worried people may get confused you can definitely add a little note when it's running with the default to help indicate to people that they may accidentally be searching the wrong registry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants