Yda 5480 expiration date schema options #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
claravox
commented
Oct 13, 2023
| """Is this schema at least a correctly formatted schema-id?""" | ||
| if schema_id == "": | ||
| return True | ||
| return re.search(r"^[a-zA-Z0-9\-]+\-[0-9]+$", schema_id) is not None |
There was a problem hiding this comment.
Is this check too restrictive?
There was a problem hiding this comment.
This is a bit stricter than the current schema name format definition (https://github.com/UtrechtUniversity/yoda/blob/development/docs/design/metadata/adr-schema-identifiers.md), but I like the change. As far as I'm concerned, let's use this regex and update the docs.
stsnel
approved these changes
Oct 16, 2023
There was a problem hiding this comment.
Excellent, looks good to me 👍
We may also need to update the default metadata schema for Yoda 1.9 in the group manager and client tools (e.g. to default-3 or just the instance/category default one), but that's outside of the scope of this ticket and can be updated later if needed, after this PR has been merged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also updated a comment to the ruleset as part of this. UtrechtUniversity/yoda-ruleset#346