Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ortho 7 - beta bugs #1280

Open
1 of 2 tasks
bobular opened this issue Nov 19, 2024 · 2 comments
Open
1 of 2 tasks

Ortho 7 - beta bugs #1280

bobular opened this issue Nov 19, 2024 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@bobular
Copy link
Member

bobular commented Nov 19, 2024

  • Pfam filter button is now a bit crazy (probably related to the change @bobular recently made allowing ReactNode rendering
  • filters freeze up with multiple pfam filters active (explanation in comment below)

image

@bobular bobular added the bug Something isn't working label Nov 19, 2024
@bobular
Copy link
Member Author

bobular commented Nov 19, 2024

Freezing pfam filters

OG7_0000397

Select 5 or 6 domains NOT including the most prevalent one (21k proteins) and everything is fine.

When the filter includes the top Pfam domain, everything gets very sluggish. For example, try to open the Proteins filter.

Sometimes it even freezes everything filter- and table-related up.

@bobular
Copy link
Member Author

bobular commented Nov 21, 2024

Having trouble with the second item. What I know

  1. it's a problem with Popover cleanup - the overlay is persisting causing inability to interact with the filters (and the table, other than general page scrolling)
  2. this was last seen pervasively when the dependency to useImperativeHandle was missing
  3. it only seems to happen with some (large?) groups and some Pfam domain selections (haven't seen it with the taxon filter but haven't played with it so much)
  4. the OG7_0000397 example seems to hinge around the popular Pfam at the domain being checked
  5. the most bizarre thing is that if you select all with the link at the bottom of the Pfam filter, the filtering is still a bit slow, but the buttons remain responsive - this may be key to understanding the issue

I tried various things none of them helped! (sorry to be vague)
It doesn't seem to be an interaction with useDeferredValue because the pfamFilter element is rendered with only volatile data (pfamRows is stable, right?)

Any ideas @dmfalke ?

@bobular bobular linked a pull request Nov 21, 2024 that will close this issue
@bobular bobular removed a link to a pull request Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant