Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add possibility to play Bink encoded videos in addition to existing player #77

Open
DCxDemo opened this issue Jan 24, 2021 · 3 comments
Labels
suggestion The proposed feature is open to discussion

Comments

@DCxDemo
Copy link
Collaborator

DCxDemo commented Jan 24, 2021

Since thps4 Bink backend is used to play videos, however, gearbox used some MPEG player instead. Also, Xbox version of the game features higher quality videos in Bink format (480p vs 240p). Could add support for those.

@DCxDemo DCxDemo added the suggestion The proposed feature is open to discussion label Jan 24, 2021
@Vadru93
Copy link
Owner

Vadru93 commented Jan 25, 2021

The only problem I see with this issue is including binkw32.dll, since it’s copyrighted. But maybe there are some opensource bink decoder?

@DCxDemo
Copy link
Collaborator Author

DCxDemo commented Jan 25, 2021

we can leave that burden up to user, check if bink is present, then try play bik files, if not, use old player.
like user will have to copy videos themselves anyways.
it might be tricky though as it has to be some specific version with an instruction like "copy bink from th4/ug1/ug2"...

@DCxDemo DCxDemo changed the title Change movie player to Bink Add possibility to play Bink encoded videos in addition to existing player Jan 25, 2021
@mirh
Copy link

mirh commented Jan 4, 2022

It's not really rocket science to ship your own decoding library

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
suggestion The proposed feature is open to discussion
Projects
None yet
Development

No branches or pull requests

3 participants