Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

einsum support for generalized product involving tensor-of-tensor and regular tensor #437

Merged
merged 94 commits into from
Jan 8, 2024
Merged

einsum support for generalized product involving tensor-of-tensor and regular tensor #437

merged 94 commits into from
Jan 8, 2024

Conversation

bimalgaudel
Copy link
Member

No description provided.

evaleev and others added 30 commits November 8, 2023 10:18
@evaleev
[unit] enabled tot x t test, does not compile @bimalgaudel will fix
4ceb416
@bimalgaudel
[WIP] T x ToT overload of einsum: first attempt.
65f4374
@evaleev
tiny step towards supporting T*ToT in expr
ab0698d
@bimalgaudel
Merge pull request #433 from ValeevGroup/gaudel/feature/t_x_tot_expr_…
a60315d 
…support

tiny step towards supporting T*ToT in expr
@bimalgaudel
[WIP]: Make binary_egine less restrictive on left and right arg types.
a9a6b58
@evaleev
Merge branch 'master' into gaudel/feature/t_x_tot
c2998a5
@evaleev
moar ToT * T progress
e4eb2c9
@bimalgaudel
[skip_ci] add permutation optimizer for general case: supports inner …
b80d1c4 
…operation between tot * t.
@bimalgaudel @evaleev
add permutation optimizer for scaling
c199457
@evaleev
expression-level support for ToT x T (and vice versa) implemented, ne…
bff7d28 
…ed to test
@bimalgaudel
Merge remote-tracking branch 'origin/gaudel/feature/t_x_tot' into gau…
f814cf6 
…del/feature/t_x_tot

# Conflicts:
#	src/TiledArray/expressions/permopt.h
@bimalgaudel
[ci skip] implement 'i,j;m,n * j,k -> i,j,k;m,n' reference evaluation…
72e1bcb 
… manually.
@bimalgaudel
[ci skip] more manual tot * t reference evaluation
c694053
@bimalgaudel
Add equality comparison for SparseShape<T>.
29b5dba
@bimalgaudel
Validate outer-product type tot * t evaluation using expression layer.
f2945da
@evaleev
[unit] einsum_tot_t pulls remote tiles using strick blocking (dowork=…
be06fbe 
…false)

also fixed a few typos
@evaleev
[unit] einsum_tot_t must test ToT*T AND T*ToT (the latter is currentl…
3cd64db 
…y broken due to missing Tensor functionality for binary Scalar*Tensor ops)
@bimalgaudel
Avoid code-duplication by generalizing the existing einsum function.
f246756
@bimalgaudel
In einsum, handle inner index labels when tot times t, or, t times to…
e5ec531 
…t arguments are passed.
@evaleev
amend bff7d28
8341bbb
@evaleev
relax type requirements on tensor_init to support mixed (ToT alongsid…
56b49a0 
…e T) invocations, this allows T * ToT expr to compile and unit test to succeed
@evaleev
relax Tensor(left,right,binaryelemeop,permutation) ctor constraints
b75b1fc
@bimalgaudel
Support for pure hadamard product between a tot and a t: 'i,j;m,n * i…
f8d4100 
…,j -> i,j;m,n'
@bimalgaudel
SparseShape inequality comparison added.
726ebb8
@bimalgaudel
Disable shape comparison in ToTArrayFixture.
7fd52d5
@bimalgaudel
Default construction of result tensor tile in einsum made more gene…
cdc9db2 
…ric.
@bimalgaudel
Restore (optional) shape comparison on ToTArrayFixture::are_equal fun…
d2fb429 
…ction.
@bimalgaudel
Relax restricitons on this->product_type() values while calling make_…
42fb41b 
…tile_op().
@bimalgaudel
Typo.
7b7dbb8
@bimalgaudel
[skip ci] einsum unit test for
02a7db7 
ij;mn * kj;mn -> ijk;mn
bimalgaudel and others added 28 commits December 21, 2023 15:22
@bimalgaudel
einsum tot x tot 'i,j;m,n * j,k;m,n -> i,jk;m,n' unit-test compares r…
f001847 
…esults
@bimalgaudel
Make shape comparison flags more explicit.
f4bba8e
@bimalgaudel
Merge remote-tracking branch 'origin/gaudel/feature/t_x_tot' into gau…
06656da 
…del/feature/t_x_tot

# Conflicts:
#	tests/einsum.cpp
#	tests/tot_array_fixture.h
@evaleev
use version-controlled clang-format.sh from https://github.com/Valeev…
0c30bb3 
…Group/DevOps/blob/master/tools/clang-format/clang-format.sh
@evaleev
[ut] einsum_tot/ijk_mn_eq_ij_mn_times_kj_mn : how NOT to compute ref_…
ba0be00 
…result
@evaleev
[ut] einsum_tot/ijk_mn_eq_ij_mn_times_kj_mn : how to compute ref_result
987040b
@bimalgaudel
[ut] ref result manual computation pattern from previous commit appli…
2392f20 
…ed to more cases.
@bimalgaudel
[ut] typo
8b365a9
@bimalgaudel
[ci skip] add .batched_size() method to Tensor that returns size() mu…
6c7a9f4 
…ltiplied by batch_size().
@bimalgaudel
Tensor reduce works on batch_size() * volume() many elements.
6032702
@evaleev
Merge branch 'master' into gaudel/feature/t_x_tot
c2d4d88
@bimalgaudel
Rename TA::Tensor member function 'batched_size' to 'total_size'.
959c84f
@bimalgaudel
Merge remote-tracking branch 'origin/gaudel/feature/t_x_tot' into gau…
8b6bb17 
…del/feature/t_x_tot
@evaleev
[cmake] disable clang-format use by umpire/blt
f0cd2a9
@bimalgaudel
Rename TA::Tensor and TA::Tile member function 'batch_size' to more r…
0d4d2b6 
…evealing 'nbatch'.
@bimalgaudel
Generic scalar_type instead of a cpp literal value
efb852e
@evaleev
bump MADNESS tag to pull in m-a-d-n-e-s-s/madness#512
c32a541
@evaleev
introduced TensorImpl::local_nnz
74759c7
@evaleev
annotate virtual DistEval class members with override
f3716f8
@evaleev
if MADNESS configured with ENABLE_WORLDOBJECT_FUTURE_TRACE trace futu…
ee1b367 
…res associated with DistributedStorage

bump MADNESS tag to pull in m-a-d-n-e-s-s/madness#514
@evaleev
binary_wrapper.h: hush warnings due to implicitly capture of this
886ec19
@evaleev
reimplement ArrayEvalImpl::internal_eval() using TensorImpl::local_nnz()
c3a36dc
@bimalgaudel
Bug fix.
a9c7e62
@bimalgaudel
Remove [=] capture when not needed.
c16ecc1 
[=, this] is C++20 extension. A warning is issued by clang-17 at least.
@evaleev
introduced TA_TRACE_GLOBAL_COMM_STATS CMake option that enables traci…
bc1b712 
…ng stats of communication within global objects (DistEval's + DistributedStorage)
@evaleev
if configured with TA_TRACE_GLOBAL_COMM_STATS will collect stats of D…
56e0e2e 
…istEval comms
@evaleev
DistributedStorage::get() can use (2 types of) caching if requested b…
78e8ad3 
…y user

if configured with TA_TRACE_GLOBAL_COMM_STATS will collect stats of DistributedStorage comms
@evaleev
bump MADNESS tag to pull in m-a-d-n-e-s-s/madness#516 which fixes han…
989fd8e 
…gs in applications with large number of tasks
@evaleev evaleev merged commit 1dea847 into master Jan 8, 2024
9 checks passed
@evaleev evaleev deleted the gaudel/feature/t_x_tot branch January 8, 2024 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bimalgaudel @evaleev