Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Indexes should support more types to deal with Postgresql indexes #56

Closed
pierresouchay opened this issue Jan 15, 2025 · 3 comments
Closed

Comments

@pierresouchay
Copy link
Contributor

Indexes seem to support only hash and btree

But just to name Postgresql, there are many other index types:

@Vanderhoof We can either add those values in the enum or maybe allow any kind of value, do you have an opinion on the subject?

@Vanderhoof
Copy link
Owner

Hi @pierresouchay!
Thanks for raising this question. Originally I was relying on the DBML docs saying:

type: type of index (btree, gin, gist, hash depending on DB). For now, only type btree and hash are accepted.

But I just checked and saw that the official dbml2sql does accept arbitrary values for an index type, so I see no reason why we should limit it in PyDBML either.

And thanks for implementing the extra indexes, I will apply your PR shortly

@pierresouchay
Copy link
Contributor Author

@Vanderhoof indeed, a colleague of mine had the issue with sql2dbml tool... Thanks a lot!

PS: thank you for your work on this lib, and it would be amazing if you could do a release not before too long.

@Vanderhoof
Copy link
Owner

Vanderhoof commented Jan 15, 2025

Sure, I will do the release within an hour!
UPD: Done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants