✨ Prototype DN420 #118
Merged
✨ Prototype DN420 #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I just discovered this PR after reading your reply on X. While I believe you may have a more refined implementation of this idea, I would appreciate knowing if you would permit me to add my implementation to the ERC if the PR be merged into the main branch later. Here are the links to the PR of the ERC and the discussion. Of course, feel free to inform me if you and your big brain friends would like to be added as authors as this PR exist for quite awhile compare to the ERC PR with most of the ideas were inspired from DN404 / ERC7631. |
|
I'll merge this first. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The aim is to build the "most efficient" single dual-nature contract,
that is also scalable in the long term (no out-of-gas DoS vectors even with millions of trades),
and usable for IPFS token URIs with per-token unique metadata.
This is still extremely hot and experimental.
I haven't got the rest of the avengers to internal audit this yet.
USE AT YOUR OWN RISK
Tbh, I think that ERC721 is a more flexible option in the long term, mainly because of
ownerOf.Past a certain point, there is only so much gas you can save before eating into UX.
Always take benchmarks (including ours) with a pinch of salt, as they can be cheesed.
Update:
May merge soon once all the fixes are in. But for battle-tested safety and versatility, I'd still recommend DN404.
Checklist
Ensure you completed all of the steps below before submitting your pull request:
forge fmt?forge snapshot?forge test?Pull requests with an incomplete checklist will be thrown out.