Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

githubpp repository not available #1

Open
Scorg opened this issue Apr 5, 2022 · 7 comments
Open

githubpp repository not available #1

Scorg opened this issue Apr 5, 2022 · 7 comments

Comments

@Scorg
Copy link

Scorg commented Apr 5, 2022

Hello. I want to help porting MO2 to linux.

Currently the download script fails to access https://github.com/ChipmunkV/githubpp repository listen in dependencies.

I will try to use the one from ModOrganizer2 for now.

@VelorumS
Copy link
Owner

VelorumS commented Apr 5, 2022

Those repos are copies of the ones in the https://github.com/orgs/ModOrganizer2/repositories

The githubpp probably didn't need any changes so I didn't make a copy of that repo. I've added it anyway now.

Overall stuff left to do for a minimal port:

  • virtual filesystem (I call it omapvfs)
  • fit the virtual filesystem into modorganizer by adding plugin mechanism for filesystems or putting it directly instead of usvfs
  • debug the code that deals with going through files and archives
  • rethink the code that launches Steam/Lutris and games
  • the winapi-PrivateProfile.sh INI file reader/writer and its use in modorganizer

@Scorg
Copy link
Author

Scorg commented Apr 6, 2022

Thank you for quick response.

This may be a wrong place to ask, but does the repo compile? I'm can't even get to compilation step - I get errors from cmake about gtest not being available.

@VelorumS
Copy link
Owner

VelorumS commented Apr 6, 2022

Overall it builds, but I may have different packages installed.

For gtest need to install the libgtest-dev package. It happened to be installed on my machine so I haven't noticed it and haven't added it to the list in the modorganizer-deb-packaging/modorganizer/debian/control.

To catch all dependencies I intended to make a minimal Ubuntu install, test the build and then add missing packages to modorganizer-deb-packaging/modorganizer/debian/control in the end.

@Scorg
Copy link
Author

Scorg commented Apr 6, 2022

Strange. I have libgtest-dev installed but cmake still can't find it

@Scorg
Copy link
Author

Scorg commented Apr 7, 2022

Ok, so I got to the building step. I had to replace gtest and gtest_main with GTest::GTest and GTest::Main resectively. I messed a bit more in cmake_common and other projects and it seems that most of the dependencies I have are older than required (I'm on Mint 20.3):

  • gcc is 9.4 but at least 10 is needed (not a big problem, I installed 11. I may be wrong, but this should not affect end users);
  • Qt is 5.12 but 5.15 is required (5.12 is missing some new constructors and a moved enum, this should be fixable);
  • boost is 1.71 but at least 1.73 is required (1.71 is incompatible with c++20 standard which removed a std::allocator::pointer member. Looks like boost 1.73+ is not getting included any time soon, and I don't know if static linking would work, of if binaries are compatible).

@VelorumS
Copy link
Owner

VelorumS commented Apr 7, 2022

In the readme it's mentioned that you need at least Ubuntu 22.04 LTS.

It has all those things: gtest with a proper cmake script /usr/lib/x86_64-linux-gnu/cmake/GTest/GTestConfig.cmake, gcc 11, recent boost, Qt 5.15.

@Scorg
Copy link
Author

Scorg commented Apr 7, 2022

Oh, my bad then. I'm blind.
Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants