Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Plugin: Custom folder icons #2558

Open
wants to merge 28 commits into
base: dev
Choose a base branch
from
Open

New Plugin: Custom folder icons #2558

wants to merge 28 commits into from
+256 −0

Conversation

sadan4
Copy link
Contributor

@sadan4 sadan4 commented Jun 7, 2024

Vencord/plugin-requests#638
This adds custom folder icons.

This is my first time writing a serious plugin and working with React.

Feel free to leave ideas and criticism.

@sadan4 sadan4 mentioned this pull request Jun 7, 2024
Open
3 tasks
@Z4ne4what

This comment was marked as off-topic.

Sign in to view
@sadan4 sadan4 marked this pull request as draft June 12, 2024 20:06
@dbidwell94
Copy link

Can this be expanded on to allow for custom server icons as well? There are a lot of times where servers will change icons and because I have a lot of servers, it takes a while for me to re-find those servers. But having a custom icon would solve this issue

@sadan4
Copy link
Contributor Author

sadan4 commented Jun 17, 2024

Can this be expanded on to allow for custom server icons as well? There are a lot of times where servers will change icons and because I have a lot of servers, it takes a while for me to re-find those servers. But having a custom icon would solve this issue

I do not plan on that for this pr

@andriemc

This comment was marked as off-topic.

Sign in to view
@sadan4 sadan4 marked this pull request as ready for review June 30, 2024 04:10
@sadan4
Copy link
Contributor Author

sadan4 commented Jun 30, 2024

I think this is ready, open to feedback.

Scyye
Scyye reviewed Jul 2, 2024
View reviewed changes
Copy link
Contributor

@Scyye Scyye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few nitpicks, overall, pretty well written.

src/plugins/customFolderIcons/README.md Outdated Show resolved Hide resolved
src/utils/constants.ts Outdated Show resolved Hide resolved
src/plugins/customFolderIcons/index.tsx Outdated Show resolved Hide resolved
@Ransomwave
Copy link

Hey, how do I add this to my client?

@sadan4
Copy link
Contributor Author

sadan4 commented Jul 27, 2024

Hey, how do I add this to my client?

Wait for it to be merged

@Ransomwave
Copy link

Ransomwave commented Jul 27, 2024 •
edited
Loading

Wait for it to be merged

In case it doesn't get merged, how do I add this to my client?

@andriemc
Copy link

Wait for it to be merged

In case it doesn't get merged, how do I add this to my client?

Either:

  1. You don't.
    or
  2. You clone the fork and install vencord from it.

@sadan4
Copy link
Contributor Author

sadan4 commented Jul 27, 2024

Wait for it to be merged

In case it doesn't get merged, how do I add this to my client?

I might release it as a user plugin while it waits to get merged
If you can't figure that out, then just wait.

@sadan4 sadan4 changed the base branch from main to dev September 2, 2024 05:08
@Nuckyz Nuckyz force-pushed the dev branch 9 times, most recently from fa092cf to eb63a54 Compare September 23, 2024 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Scyye Scyye Scyye left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@sadan4 @Z4ne4what @dbidwell94 @andriemc @Ransomwave @Scyye