Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(commandHelpers): Switch from logical OR to nullish coalescing for findOption() #3047

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

fix(commandHelpers): Switch from logical OR to nullish coalescing for findOption() #3047

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
b3773ab
Add support for onAuxClick.
EtorixDev Nov 24, 2024
4142739
Switch from logical OR to nullish coalescing.
EtorixDev Nov 25, 2024
a297852
Merge remote-tracking branch 'upstream/main'
EtorixDev Nov 25, 2024
6b04d4b
Merge remote-tracking branch 'upstream/main' into findoption
EtorixDev Nov 25, 2024
b81d10e
Merge branch 'findoption'
EtorixDev Nov 25, 2024
96cafec
Merge remote-tracking branch 'upstream/main'
EtorixDev Nov 25, 2024
8103e25
Merge branch 'main' into findoption
EtorixDev Nov 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/api/Commands/commandHelpers.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,5 +54,5 @@ export function sendBotMessage(channelId: string, message: PartialDeep<Message>)
export function findOption<T>(args: Argument[], name: string): T & {} | undefined;
export function findOption<T>(args: Argument[], name: string, fallbackValue: T): T & {};
export function findOption(args: Argument[], name: string, fallbackValue?: any) {
return (args.find(a => a.name === name)?.value || fallbackValue) as any;
return (args.find(a => a.name === name)?.value ?? fallbackValue) as any;
}