Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert test runners into build steps #543

Open
Vexu opened this issue Nov 8, 2023 · 4 comments
Open

Convert test runners into build steps #543

Vexu opened this issue Nov 8, 2023 · 4 comments
Labels
enhancement New feature or request

Comments

@Vexu
Copy link
Owner

Vexu commented Nov 8, 2023

For reference look at Cases.zig.

@Vexu Vexu added the enhancement New feature or request label Nov 8, 2023
@eightfilms
Copy link
Contributor

would like to try to tackle this, if this is not being worked on already

@Vexu
Copy link
Owner Author

Vexu commented Nov 26, 2023

Not that I know. I'd recommend starting with the integration tests and converting a few different types of tests first and then making a PR.

@eightfilms
Copy link
Contributor

@Vexu sorry, was away for a while and didn't have time to look at this - finally got a good look just now.

Have a quick question to understand how I can approach this: What is the end goal of this change? Is this to be able to eventually move towards being able to classify tests in categories (eg. errors, expected types, etc.)? Right now from my (very amateur) understanding the advantage of the approach in the zig repo is being able to have test manifests and to be able to test according to category (error, compile, translate-c). This contrasts with arocc, which can only do the integration tests wholesale now. I'm imagining the goal here is to move towards a more modular test runner?

@Vexu
Copy link
Owner Author

Vexu commented Jan 16, 2024

No need to apologize, you're volunteering and any help is appreciated!

Being able to more explicitly classify tests is one goal. The tests are already classified but it's based on different flags and macros being set. Other benefits from the change will be the build systems built-in parallelism and caching in some cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants