Duplicate long typedef disallowed

[ehaas]

Duplicate typedefs should be allowed if they're equal. This one is weird; it seems it only happens for long (not long int or unsigned long or any other specifier):

typedef long foo;
typedef long foo;

test.c:2:17: error: expected identifier or '('
typedef long foo;
                ^

[ehaas]

Happens because the existing typedef we find here:

arocc/src/aro/Parser.zig

Line 2069 in 8ab72a4

const typedef = (try p.syms.findTypedef(p, interned_name, p.tok_i, ty.specifier != .none)) orelse break;

Gets combined with long to form a long long specifier here:

arocc/src/aro/Parser.zig

Line 2070 in 8ab72a4

if (!ty.combineTypedef(p, typedef.ty, typedef.tok)) break;

That also led me to suspect other patterns could trigger it:

typedef double foo;
typedef long foo;

test.c:2:17: error: expected identifier or '('
typedef long foo;
                ^

[aidenfoxivey]

Is there error message here also considered a bug? It seems pretty vague - like I wouldn't understand it by default.

[Vexu]

The bug here is that there shouldn't be any errors.