feat: implement __has_declspec_attribute
#514
Merged
+32
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eightfilms
commented
Sep 30, 2023
src/target.zig
Outdated
| @@ -684,6 +684,7 @@ pub fn toLLVMTriple(target: std.Target, buf: []u8) []const u8 { | |||
| .watchos => "watchos", | |||
| .driverkit => "driverkit", | |||
| .shadermodel => "shadermodel", | |||
| .liteos => "liteos", | |||
There was a problem hiding this comment.
I added this in order to make it compile, but #510 fixes this.
Vexu
requested changes
Sep 30, 2023
|
@Vexu Hmm, am I misundestanding the usage of at the top of the file? I was under the impression that including the args switches on the options in tests. If that's the case then the ifs would reflect accurately on the behaviour, no? |
|
No you understand correctly, I was talking about the case where |
|
Ah should I add a check there as well? I'm assuming you mean |
|
Something like that yes. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #419
CI seems to be failing, not sure if it's related to this?