New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Fishing Rod Usage #638

Closed

lowercasebtw wants to merge 1 commit into ViaVersion:main from lowercasebtw:main

Collaborator

lowercasebtw commented Dec 2, 2024

Fixes broken usage of the rod, where it wasn't working on Hypixel in 1.12/1.8.

After looking at the code, it was using the wrong method compared to what is done in 1.14.4 and below, which this fixes.

Should also fix #625


          Fix Fishing Rod Usage

80a7d24

FlorianMichael requested changes

View reviewed changes

Member

FlorianMichael left a comment

1.14.4 also has the swingHand() override in ClientPlayerEntity and the same code, so either wrong version range or wrong code from the beginning

lowercasebtw closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet