Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add "Any" option for conqueror dropdown select and search more than 200 seeds #34

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ImHamba
Copy link

@ImHamba ImHamba commented May 26, 2024

DEMO: https://imhamba.github.io/timeless-jewels

Added an "any" option for the conqueror drop down, for the purposes of searching the trade website.
image

This selection is reflected in the url params as conqueror=Any, and loading a link with this param will automatically select the Any dropdown option.

This will generate trade site queries that search for the same seed for each conqueror (if you dont care about the keystone).
image

Selecting a specific conqueror will generate trade queries that only have that conqueror:
image

This fixes a bug mentioned in various issues:
#33
#31

Additionally, fixed issue where the all 4 count filter groups would be identical (also mentioned in above issues):
Now each count group has 50 unique seeds that the user can enable/disable to search 50 seeds at a time, for a total of 200 seeds per trade search.
image
image
image
image

Also, previously if there were over 50x4 = 200 valid seeds, a single trade link would be generated for the first 200 (in practice just for 50 due to the above bug), any additional ones would just be truncated off and ignored. Now if there are over 200 seeds, the "trade" button becomes a toggle button to display multiple trade queries to cover the entire set of valid seeds.
image
image

So the user can now see all possible valid seeds returned by their search.

@ImHamba ImHamba changed the title Add "Any" option for conqueror dropdown select feat: Add "Any" option for conqueror dropdown select and search more than 200 seeds May 26, 2024
@ImHamba ImHamba changed the title feat: Add "Any" option for conqueror dropdown select and search more than 200 seeds feat: add "Any" option for conqueror dropdown select and search more than 200 seeds May 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant