Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fetch到的課程錯ㄌ #4

Open
JorrhukMB opened this issue Sep 9, 2022 · 3 comments
Open

fetch到的課程錯ㄌ #4

JorrhukMB opened this issue Sep 9, 2022 · 3 comments

Comments

@JorrhukMB
Copy link

JorrhukMB commented Sep 9, 2022

image
增加課程 > 課程代碼輸入上面ㄉ A215500-40 後
跑出來的課是錯的
image
這堂應該是 A215500-48 才對
image

@JorrhukMB JorrhukMB changed the title fetch2l4 fetch到的課程錯ㄌ Sep 9, 2022
@Vincent550102
Copy link
Owner

Vincent550102 commented Oct 1, 2022

會發生這個問題的原因是資料來源若遇到重複的課程會用我自己的方式下去做編碼,所以在 111data.json 上看到的編號並非正確的課程碼。

可以解決的方式有以下方案。

  • 找一個更好的資料來源,能夠取得正確的課程碼
  • 做一個更好的搜尋方式,避免使用課程碼做課程搜尋

以上兩個方案歡迎發 PR

@Vincent550102
Copy link
Owner

出問題的 code

dictneedadd["{}-{}".format(courseid, idx)] = course

@Vincent550102
Copy link
Owner

可以改進的新增課程方式

function addClass(classid, classesJson, isparse = false) {

@Vincent550102 Vincent550102 pinned this issue Dec 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants