Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lvt names for the exceptions in catch clauses aren't emitted #445

Open
MiniDigger opened this issue Dec 16, 2024 · 0 comments
Open

lvt names for the exceptions in catch clauses aren't emitted #445

MiniDigger opened this issue Dec 16, 2024 · 0 comments
Labels
Priority: Low Low priority Subsystem: Variables Anything concerning variables, types, assignments, and casting Type: Bug Something isn't working

Comments

@MiniDigger
Copy link
Contributor

Vineflower version

1.11 @ ef138de

Describe the bug

right now var names are just auto incremented here https://github.com/Vineflower/vineflower/blob/master/src/org/jetbrains/java/decompiler/modules/decompiler/stats/CatchStatement.java#L50, I expect to see the name listed in the lvt.

Additional information

https://github.com/Vineflower/vineflower/blob/master/testData/src/java8/pkg/TestTryCatchFinally.java#L28 is emitted as var8, not e2
https://github.com/Vineflower/vineflower/blob/master/testData/results/pkg/TestTryCatchFinally.dec#L10

from discord:

i believe it's because the variables the catch statement adds are synthetic
basically to fix it i think the catch variables need to be associated with lvts
~ Jasmine

MiniDigger added a commit to MiniDigger/vineflower that referenced this issue Dec 16, 2024
MiniDigger added a commit to MiniDigger/vineflower that referenced this issue Dec 16, 2024
@jaskarth jaskarth added Type: Bug Something isn't working Priority: Low Low priority Subsystem: Variables Anything concerning variables, types, assignments, and casting labels Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: Low Low priority Subsystem: Variables Anything concerning variables, types, assignments, and casting Type: Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants