Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cityscape.py did not filter the target domain images #23

Open
qimw opened this issue Nov 12, 2019 · 2 comments
Open

cityscape.py did not filter the target domain images #23

qimw opened this issue Nov 12, 2019 · 2 comments

Comments

@qimw
Copy link

qimw commented Nov 12, 2019

After using prepare_data.m, source domain images and target domain images are recorded in the same trainval.txt.
In the foggy_cityscape.py, source domain images are filtered in _load_image_set_index(), but in cityscape.py, the target domain are not filtered. Do you regard all the images in trainval.txt as source domain ?

@weix-liu
Copy link

I found this problem, too.
If the set of target domains is filtered out, the final result may be much lower than the result claimed in the paper.
I will retest this change。

@weix-liu
Copy link

I've retested this part (filtering out target domain images)
The result is 32.61, which is similar to 34.3 in the paper.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants