Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hostname is part of url in database #51

Open
andyneff opened this issue Apr 7, 2016 · 0 comments
Open

Hostname is part of url in database #51

andyneff opened this issue Apr 7, 2016 · 0 comments

Comments

@andyneff
Copy link
Member

andyneff commented Apr 7, 2016

The hostname becomes part of the url in certain database types, such as point cloud, images, etc..

This makes the database very inflexible when it comes to changing hostnames, using https vs http, etc...

Inlead of storing the actual url, a variable substitutable url could be stored, for example

{IMAGE_SERVER}/images/12345/image.jpg

The two functionalities can be added.

  1. Add the ability to form the real url in the DRF side. This will become the endpoint for client side code to hit to get urls that are needed. The default value for the {IMAGE_SERVER} should be blank. This way it becomes a URI that would work regardless of hostname. {IMAGE_SERVER} would only be set in the more advanced case where the image server is actually only being served from a different location. Some form of cross authentication will have to be set up for this use case
  2. Add a function to take this url and turn it into a file location. This will be used for the django apps.

It would be best to do this AFTER history is removed (#39), and AFTER the javascript apps are re-written to use all DRF endpoints

andyneff added a commit that referenced this issue Nov 1, 2016
Added Let's Encrypt capabilities to Voxel Globe
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant