From 95245bd13b7b5d1879d7502a0183d965b376c7f1 Mon Sep 17 00:00:00 2001 From: andrea rota Date: Tue, 19 Sep 2023 11:17:19 +0100 Subject: [PATCH 1/3] upgrade fountainhead/action-wait-for-check to v1.1.0 v1.0.0 runs on EOL NodeJS v12; v1.1.0 runs on NodeJS v16. --- .github/workflows/deploy-to-kubernetes.yml | 8 ++++---- .github/workflows/publish-marxan-docker-images.yml | 4 ++-- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/.github/workflows/deploy-to-kubernetes.yml b/.github/workflows/deploy-to-kubernetes.yml index 454924df33..85c2c807eb 100644 --- a/.github/workflows/deploy-to-kubernetes.yml +++ b/.github/workflows/deploy-to-kubernetes.yml @@ -22,7 +22,7 @@ jobs: runs-on: ubuntu-22.04 steps: - name: Wait for API image to be pushed to Docker Hub - uses: fountainhead/action-wait-for-check@v1.0.0 + uses: fountainhead/action-wait-for-check@v1.1.0 with: token: ${{ secrets.GITHUB_TOKEN }} checkName: Push API Docker image to Azure Container Registry @@ -30,7 +30,7 @@ jobs: intervalSeconds: 30 - name: Wait for Geoprocessing image to be pushed to Docker Hub - uses: fountainhead/action-wait-for-check@v1.0.0 + uses: fountainhead/action-wait-for-check@v1.1.0 with: token: ${{ secrets.GITHUB_TOKEN }} checkName: Push Geoprocessing Docker image to Azure Container Registry @@ -38,7 +38,7 @@ jobs: intervalSeconds: 30 - name: Wait for Client image to be pushed to Docker Hub - uses: fountainhead/action-wait-for-check@v1.0.0 + uses: fountainhead/action-wait-for-check@v1.1.0 with: token: ${{ secrets.GITHUB_TOKEN }} checkName: Push Client Docker image to Docker Hub @@ -46,7 +46,7 @@ jobs: intervalSeconds: 30 - name: Wait for Webshot image to be pushed to Docker Hub - uses: fountainhead/action-wait-for-check@v1.0.0 + uses: fountainhead/action-wait-for-check@v1.1.0 with: token: ${{ secrets.GITHUB_TOKEN }} checkName: Push Webshot Docker image to Azure Container Registry diff --git a/.github/workflows/publish-marxan-docker-images.yml b/.github/workflows/publish-marxan-docker-images.yml index 0789a4ab86..62f137e170 100644 --- a/.github/workflows/publish-marxan-docker-images.yml +++ b/.github/workflows/publish-marxan-docker-images.yml @@ -28,7 +28,7 @@ jobs: runs-on: ubuntu-22.04 steps: - name: Wait for API tests to run - uses: fountainhead/action-wait-for-check@v1.0.0 + uses: fountainhead/action-wait-for-check@v1.1.0 with: token: ${{ secrets.GITHUB_TOKEN }} checkName: API Tests @@ -36,7 +36,7 @@ jobs: intervalSeconds: 20 - name: Wait for Client tests to run - uses: fountainhead/action-wait-for-check@v1.0.0 + uses: fountainhead/action-wait-for-check@v1.1.0 with: token: ${{ secrets.GITHUB_TOKEN }} checkName: Client Tests From 971fca8e0c43ae9108121021f82c691612992232 Mon Sep 17 00:00:00 2001 From: andrea rota Date: Tue, 19 Sep 2023 11:24:30 +0100 Subject: [PATCH 2/3] install kubectl from current pkgs.k8s.io deb repository Using v1.25 as cluster is currently on v1.24 and we can rely on a +1/-1 drift (aka we can upgrade the cluster up to v1.26 while keeping kubectl functional in GH actions). --- .github/workflows/deploy-to-kubernetes.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/deploy-to-kubernetes.yml b/.github/workflows/deploy-to-kubernetes.yml index 85c2c807eb..7af04091b3 100644 --- a/.github/workflows/deploy-to-kubernetes.yml +++ b/.github/workflows/deploy-to-kubernetes.yml @@ -82,8 +82,8 @@ jobs: - name: Install kubectl run: | - sudo curl -fsSLo /usr/share/keyrings/kubernetes-archive-keyring.gpg https://packages.cloud.google.com/apt/doc/apt-key.gpg - echo "deb [signed-by=/usr/share/keyrings/kubernetes-archive-keyring.gpg] https://apt.kubernetes.io/ kubernetes-xenial main" | sudo tee /etc/apt/sources.list.d/kubernetes.list + sudo curl -fsSL https://pkgs.k8s.io/core:/stable:/v1.28/deb/Release.key | sudo gpg --dearmor -o /etc/apt/keyrings/kubernetes-apt-keyring.gpg + echo 'deb [signed-by=/etc/apt/keyrings/kubernetes-apt-keyring.gpg] https://pkgs.k8s.io/core:/stable:/v1.25/deb/ /' | sudo tee /etc/apt/sources.list.d/kubernetes.list sudo apt-get update sudo apt-get install -y kubectl From b7ab2119bec6252e6bd9d1697614d681ed2cf499 Mon Sep 17 00:00:00 2001 From: andrea rota Date: Tue, 19 Sep 2023 11:29:57 +0100 Subject: [PATCH 3/3] replace leftover use of set-output in GH actions workflow --- .github/workflows/cypress.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/cypress.yml b/.github/workflows/cypress.yml index 43f91906d3..d524231894 100644 --- a/.github/workflows/cypress.yml +++ b/.github/workflows/cypress.yml @@ -28,7 +28,7 @@ jobs: - name: Get yarn cache directory path id: yarn-cache-dir-path - run: echo "::set-output name=dir::$(yarn cache dir)" + run: echo "dir=$(yarn cache dir)" >> $GITHUB_OUTPUT - name: Yarn cache uses: actions/cache@v2